Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(backport): Lower tolerance for iminuit v2.26.0+ on Apple silicon #2515

Merged
merged 1 commit into from
Jun 7, 2024
Merged

test(backport): Lower tolerance for iminuit v2.26.0+ on Apple silicon #2515

merged 1 commit into from
Jun 7, 2024

Conversation

meeseeksmachine
Copy link

@meeseeksmachine meeseeksmachine commented Jun 7, 2024 •
edited by matthewfeickert
Loading

Backport PR #2514: test: Lower tolerance for iminuit v2.26.0+ on Apple silicon

* Backport PR https://github.com/scikit-hep/pyhf/pull/2514
* Lower the tolerance for the tests/test_optim.py test_optim_uncerts test
  to reach agreement for iminuit v2.26.0+ on Apple silicon.

@lumberbot-app lumberbot-app bot added tests pytest fix A bug fix labels Jun 7, 2024
@matthewfeickert matthewfeickert self-assigned this Jun 7, 2024
@matthewfeickert matthewfeickert changed the title Backport PR #2514 on branch release/v0.7.x (test: Lower tolerance for iminuit v2.26.0+ on Apple silicon) test(backport): Lower tolerance for iminuit v2.26.0+ on Apple silicon Jun 7, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/v0.7.x@2ee885c). Learn more about missing BASE report.

Additional details and impacted files 
@@                Coverage Diff                @@
##             release/v0.7.x    #2515   +/-   ##
=================================================
  Coverage                  ?   98.19%           
=================================================
  Files                     ?       69           
  Lines                     ?     4547           
  Branches                  ?      804           
=================================================
  Hits                      ?     4465           
  Misses                    ?       49           
  Partials                  ?       33
Flag Coverage Δ
contrib 97.73% <ø> (?)
doctest 98.02% <ø> (?)
unittests-3.10 96.19% <ø> (?)
unittests-3.11 96.19% <ø> (?)
unittests-3.12 96.19% <ø> (?)
unittests-3.7 96.17% <ø> (?)
unittests-3.8 96.21% <ø> (?)
unittests-3.9 96.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit 13e3877 into scikit-hep:release/v0.7.x Jun 7, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewfeickert matthewfeickert

Labels
fix A bug fix tests pytest
Projects
pyhf v0.7.7
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meeseeksmachine @matthewfeickert